Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Brazillian Portuguese translation #778

Merged
merged 2 commits into from
Dec 5, 2021
Merged

Improve Brazillian Portuguese translation #778

merged 2 commits into from
Dec 5, 2021

Conversation

diegodelmondes
Copy link
Contributor

Fix typos, improve the translation in general and translate some English strings.

Fix typos, improve the translation in general and translate some English strings.
@diegodelmondes
Copy link
Contributor Author

pinging @netrik182 @botoserelepe for review/suggestions.

@netrik182
Copy link
Contributor

netrik182 commented Aug 14, 2021 via email

Copy link
Contributor

@netrik182 netrik182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid translation overall. But as noted in the comments, I'd rather keep the moneroj notation to match the English version.

app/src/main/res/values-pt-rBR/strings.xml Show resolved Hide resolved
app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
@netrik182
Copy link
Contributor

Sorry for the delay in reviewing it @m2049r

@m2049r
Copy link
Owner

m2049r commented Sep 5, 2021

@diegodelmondes i also think that we should stick to moneroj as @netrik182 suggests.

thanks to both of you for all this!

@diegodelmondes
Copy link
Contributor Author

Sorry for the delay.

Now using "moneroj" instead of moneros

Copy link
Contributor

@netrik182 netrik182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@m2049r m2049r merged commit cdc2b23 into m2049r:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants